Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Movie Project #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

My Movie Project #11

wants to merge 1 commit into from

Conversation

kibosh-josh
Copy link

No description provided.

<h3 id ="error3">Please go back and enter a different movie name.</h3>
<br><br><br><br><br><br><br>
<a class ="button" id="second_button" href="/">Go Back</a>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your app and I don't see too much room for improvement. Which is good. I like your error messages if @movies == nil. I see that you use a lot of
tags. I think that you could accomplish the same thing by using css. You have id tags in each div, so you could assign padding or margin to the top and bottom that could give you the space you want. I think that would be cleaner than all the
tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants